Enabling user callbacks during zoom/pan

14 Responses

1. 
   Walter Roberson October 28, 2015 at 07:57 Reply

   Thanks for the fix, Yair.

   I notice that you use

   [hManager.WindowListenerHandles.Enabled] = deal(false);

   [hManager.WindowListenerHandles.Enabled] = deal(false);

   Is there a benefit to doing that compared to just

   hManager.WindowListenerHandles.Enabled = false;

   hManager.WindowListenerHandles.Enabled = false;

   I could see if it was a structure array where multiple destination might be set, but it is a property ?

• 
  Yair Altman October 28, 2015 at 08:22 Reply

  @Walter – hManager.WindowListenerHandles is indeed an array of objects (not a single object), so we must enclose it with [] and use deal() in order to set all its elements’ Enabled values to false. Of course, we could also use a simple loop, but using deal is simpler and easier.

2. 
   Maurizio February 12, 2016 at 23:14 Reply

   Hi Yair, can you mix this approach with the way GUIDE sets callbacks?

   This is part of the code I’m currently using, based on your post:

   set(handles.figure1, 'KeyPressFcn', {@figure1_KeyPressFcn, handles});

   set(handles.figure1, 'KeyPressFcn', {@figure1_KeyPressFcn, handles});

   One of the actions defined in figure1_KeyPressFcn increases a variable stored in handles (handles.index) when the right arrow key is pressed. However after running your bit of code the updated value of index is lost every time (i.e. I keep incrementing the same old value). I reckon that depends on hObject not being passed to figure1_KeyPressFcn in the previous snippet of code, which makes guidata(hObject, handles) kind of useless. Unfortunately the following code returns an error (too many input arguments):

   set(handles.figure1, 'KeyPressFcn', {@figure1_KeyPressFcn, hObject, eventdata, handles});

   set(handles.figure1, 'KeyPressFcn', {@figure1_KeyPressFcn, hObject, eventdata, handles});

   Any idea?

• 
  Yair Altman February 13, 2016 at 18:56 Reply

  @Maurizio – you are wrong: the figure handle is the first input arg passed to your figure1_KeyPressFcn() callback function. Simply call handles=guidata(hObject) at the beginning of your callback and guidata(hObject,handles) after you modify handles and all should be ok.

  In other words, if you keep passing handles as a static struct input arg, then of course it will always have the same values (the values that existed when you called the set(...) command).

• 
  Maurizio February 14, 2016 at 17:19 Reply

  Oh, I see what you mean. I’ll give that a try, thanks.
  Meanwhile I fixed the problem with this line of code.

  set(handles.figure1, 'KeyPressFcn', ... @(hObject,eventdata)myGui('figure1_KeyPressFcn', hObject,eventdata,guidata(hObject)));

  set(handles.figure1, 'KeyPressFcn', ... @(hObject,eventdata)myGui('figure1_KeyPressFcn', hObject,eventdata,guidata(hObject)));

  I simply copied the anonymous function from the Property Inspector of figure1 in GUIDE.

3. 
   i3v June 4, 2016 at 18:25 Reply

   Yair,
   Thanks for the code!
   Still, it looks like these few lines is not the only thing to keep in mind.
   I was unable to find a complete, fully working example, so I’ve decided to write my own. Hope it would be helpful for those who would try to to re-define these callbacks as well.
   http://www.mathworks.com/matlabcentral/fileexchange/57496-i3v-figkeys

4. 
   David August 17, 2016 at 16:34 Reply

   I’m trying to apply this approach in the zoomIn toolbar callback:

   function zoomIn_OnCallback(hObject, eventdata, handles) [handles.mode_manager.WindowListenerHandles.Enabled] = deal(false); handles.theGui.WindowKeyPressFcn = []; handles.theGui.KeyPressFcn = @theGui_KeyPressFcn; end

   function zoomIn_OnCallback(hObject, eventdata, handles) [handles.mode_manager.WindowListenerHandles.Enabled] = deal(false); handles.theGui.WindowKeyPressFcn = []; handles.theGui.KeyPressFcn = @theGui_KeyPressFcn; end

   where handles.mode_manager was set to uigetmodemanager in the GUIDE generated OpeningFcn. I can verify in the debugger that the call is executed and the callback is being assigned to theGui handle. The callback theGui_KeyPressFcn has the desired behavior when not in zoom mode, but in zoom mode it is not being called in spite of the above code.

   Obviously I’ve missed something here, but I can’t see what it is.
   (I’m not concerned about backwards compatibility, so I skipped the try/catch)

• 
  David August 17, 2016 at 18:11 Reply

  I explored this a bit more and the problem is specific to the key input ctrl-z. Any other keystroke is passed to my callback, but ctrl-z is trapped and interpreted by the zoom’s own callback. The question remains how do I override this behavior?

5. 
   Thommy October 20, 2017 at 10:15 Reply

   Thank you mate, I’ve passed quite some time on that issue. You made my day !

6. 
   Donato March 21, 2020 at 20:12 Reply

   Hi Yair,
   it seems that in Matlab R2019b this method doesn’t work.
   Have you some solutions?

   Thanks.

• 
  Hannes August 19, 2020 at 14:05 Reply

  It is also not working for me on R2019a Update 5. Best Hannes.

• 
  Sebastian Hölz February 2, 2021 at 14:16 Reply

  I have not investigated this in detail, but I think one way to go in new versions of Matlab (>2019b) might be to use listeners to suitable figure properties, e.g.

  fig = figure; ax = axes; ls = addlistener(fig,'CurrentCharacter','PostSet',@(h,e)disp(e)); zoom on

  fig = figure; ax = axes; ls = addlistener(fig,'CurrentCharacter','PostSet',@(h,e)disp(e)); zoom on

  This solves one problem, as the KeyPress is directed to the callback function as desired. However, a new problem is that the figure loses the focus since the KeyPress is also directed to the command window.
  I have not found a quick way to solve this problem, but maybe somebody else does …

• 
  Sebastian Hölz March 5, 2021 at 01:19 Reply

  OK, Been working on this again and found a solution which works in 2020a and 2020b. Below a working example which resets the KeyPressFcn for all ui-modes after activating them. It seems it is necessary to reset the 3rd KeyPressFcn, don’t ask me what the others are for …

  HV = 'off'; fig = figure('HandleVisibility',HV); ax = axes('Parent',fig, 'HandleVisibility',HV); plot(rand(1,12),'k.-', 'Parent',ax)   hManager = uigetmodemanager(fig); addlistener(hManager,'CurrentMode','PostSet',@MonitorModeChange);   function MonitorModeChange(varargin) %hManager = uigetmodemanager(fig); if ~isempty(hManager.CurrentMode) switch hManager.CurrentMode.Name case 'Exploration.Brushing' disp('Brushing on') [hManager.WindowListenerHandles.Enabled] = deal(false); fig.KeyPressFcn{3} = @(h,e)disp('Brush KeyPressFcn replacement'); case 'Exploration.Pan' disp('Pan on') [hManager.WindowListenerHandles.Enabled] = deal(false); fig.KeyPressFcn{3} = @(h,e)disp('Pan KeyPressFcn replacement'); case 'Exploration.Zoom' disp('Zoom on') [hManager.WindowListenerHandles.Enabled] = deal(false); fig.KeyPressFcn{3} = @(h,e)disp('Zoom KeyPressFcn replacement'); case 'Exploration.Datacursor' disp('Zoom on') [hManager.WindowListenerHandles.Enabled] = deal(false); fig.KeyPressFcn{3} = @(h,e)disp('DataCursor KeyPressFcn replacement'); otherwise disp(hManager.CurrentMode.Name) end end end

  HV = 'off'; fig = figure('HandleVisibility',HV); ax = axes('Parent',fig, 'HandleVisibility',HV); plot(rand(1,12),'k.-', 'Parent',ax) hManager = uigetmodemanager(fig); addlistener(hManager,'CurrentMode','PostSet',@MonitorModeChange); function MonitorModeChange(varargin) %hManager = uigetmodemanager(fig); if ~isempty(hManager.CurrentMode) switch hManager.CurrentMode.Name case 'Exploration.Brushing' disp('Brushing on') [hManager.WindowListenerHandles.Enabled] = deal(false); fig.KeyPressFcn{3} = @(h,e)disp('Brush KeyPressFcn replacement'); case 'Exploration.Pan' disp('Pan on') [hManager.WindowListenerHandles.Enabled] = deal(false); fig.KeyPressFcn{3} = @(h,e)disp('Pan KeyPressFcn replacement'); case 'Exploration.Zoom' disp('Zoom on') [hManager.WindowListenerHandles.Enabled] = deal(false); fig.KeyPressFcn{3} = @(h,e)disp('Zoom KeyPressFcn replacement'); case 'Exploration.Datacursor' disp('Zoom on') [hManager.WindowListenerHandles.Enabled] = deal(false); fig.KeyPressFcn{3} = @(h,e)disp('DataCursor KeyPressFcn replacement'); otherwise disp(hManager.CurrentMode.Name) end end end

7. 
   Tommy January 17, 2022 at 04:41 Reply

   Just adding my implementation inspired by Sebastian and i3v.

   It handles the state reset that occurs when uimode changes. Also, has options to ignore/append for specific modes.
   https://github.com/tommyhosman/UseMyKeypress

   Only tested with 2019b and uses event.proplistener()

Leave a Reply

<pre lang="matlab">
a = magic(3);
disp(sum(a))
</pre>

Click here to cancel reply.